Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment of version numbers for nightly releases #175

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jul 31, 2024

Fixes #170. To be merged on the day that v0.9.0 is published.

@lhstrh lhstrh requested a review from petervdonovan July 31, 2024 23:16
@lhstrh lhstrh changed the title Do not increment minor version number for nightly releases Adjustment of version numbers for nightly releases Jul 31, 2024
@petervdonovan
Copy link
Contributor

This looks like it should work. I took a quick look at these steps that npm version does:

  1. Check to make sure the git working directory is clean before we get started. Your scripts may add files to the commit in future steps. This step is skipped if the --force flag is set.
    2. Run the preversion script. These scripts have access to the old version in package.json. A typical use would be running your full test suite before deploying. Any files you want added to the commit should be explicitly added using git add.
    3. Bump version in package.json as requested (patch, minor, major, etc).
    4. Run the version script. These scripts have access to the new version in package.json (so they can incorporate it into file headers in generated files for example). Again, scripts should explicitly add generated files to the commit using git add.
    5. Commit and tag.
    6. Run the postversion script. Use it to clean up the file system or automatically push the commit and/or tag.

And I think it's true that we were not making important use of any of them.

@lhstrh lhstrh force-pushed the nightly-version-fix branch from b794fbd to ed67db2 Compare October 9, 2024 17:51
@lhstrh lhstrh force-pushed the nightly-version-fix branch from ed67db2 to 24d3008 Compare October 31, 2024 17:34
@lhstrh lhstrh merged commit 262dc4a into main Oct 31, 2024
3 checks passed
@lhstrh lhstrh deleted the nightly-version-fix branch October 31, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust version number of nightly-built vscode extension
2 participants