Use of pinojs as logger instead of ulog
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axmmisaka
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Oct 12, 2023
This is to accommodate lf-lang/reactor-ts#237
axmmisaka
force-pushed
the
use-pinojs-as-logger
branch
from
71dad19 to
039c0e8
Compare
lhstrh
approved these changes
Oct 13, 2023
axmmisaka
force-pushed
the
use-pinojs-as-logger
branch
from
d56ef2b to
c072a08
Compare
|
Merge #239 first. |
1. Use namespace instead of class for Log 2. Remove duplicate code by adding a `logWithSeverity` 3. Rename `global` to `globalLogger` to avoid confusion 4. Change code/tests accordingly
axmmisaka
force-pushed
the
use-pinojs-as-logger
branch
from
7b8eea8 to
1d84174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ULog is too old, and while having a log wrapper is fine imo, the current way which we structure it is a bit too bad.
This closes #228
Last TODO: prettify the output so it's not a miserable json