Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing utils moved into reactor-c #259

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Tracing utils moved into reactor-c #259

merged 6 commits into from
Aug 18, 2023

Conversation

erlingrj
Copy link
Collaborator

Moving tracing utilities from lingua-franca to reactor-c. Also install them to /usr/local/bin.

@erlingrj erlingrj requested review from lhstrh and edwardalee August 18, 2023 06:02
util/tracing/trace_util.o Outdated Show resolved Hide resolved
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK modulo comments. Thanks for doing this!

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/ci.yml Show resolved Hide resolved
@erlingrj
Copy link
Collaborator Author

@lhstrh do you know whats going on with the test failures? Seems related to a recent merge in lingua franca

@erlingrj
Copy link
Collaborator Author

I restored a branch in the main repo and now it works. But there are some non-determinsitic federated test failures here...

@lhstrh lhstrh merged commit 582608d into main Aug 18, 2023
@cmnrd cmnrd deleted the move-tracing-utils branch August 21, 2023 13:15
@lhstrh lhstrh changed the title Move tracing utils Tracing utils moved into reactor-c Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants