Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python Target] CARLA Demo #97

Merged
merged 6 commits into from
Apr 14, 2024
Merged

[Python Target] CARLA Demo #97

merged 6 commits into from
Apr 14, 2024

Conversation

jackyk02
Copy link
Contributor

@jackyk02 jackyk02 commented Jan 29, 2024

This PR provides the code and instructions for running the CARLA simulator with Lingua Franca. For detailed guidance and troubleshooting, please refer to the README file.

@lhstrh lhstrh requested a review from petervdonovan January 29, 2024 19:58
Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be some code duplication between carla_circle.lf and carla_manual_control.lf. You could fix that by factoring out the Python code into a separate file as illustrated here.

As is usually the case with duplication, you can probably solve this using composition by creating a class that is parameterized by a procedure that implements the behavior that is different between the two implementations. But I am happy with whatever you do as long as we are not stuck maintaining two copies of mostly the same code

examples/Python/src/CARLA/README.md Outdated Show resolved Hide resolved
examples/Python/src/CARLA/README.md Show resolved Hide resolved
examples/Python/src/CARLA/README.md Outdated Show resolved Hide resolved
examples/Python/src/CARLA/carla_circle.lf Outdated Show resolved Hide resolved
examples/Python/src/CARLA/carla_manual_control.lf Outdated Show resolved Hide resolved
examples/Python/src/CARLA/carla_circle.lf Outdated Show resolved Hide resolved
@jackyk02
Copy link
Contributor Author

jackyk02 commented Feb 2, 2024

Thank you for the suggestions. I've factored out the Python code into a separate file. Please let me know if any additional changes are needed :)

Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It looks like my comments have been addressed.

@edwardalee edwardalee merged commit 8ae58a7 into lf-lang:main Apr 14, 2024
4 of 5 checks passed
@lhstrh
Copy link
Member

lhstrh commented Apr 14, 2024

I see that this was merged, but ./examples/Python/src/CARLA/src/carla_sync.lf fails to compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants