Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CARLA Demo #109

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix CARLA Demo #109

merged 1 commit into from
Apr 15, 2024

Conversation

jackyk02
Copy link
Contributor

@jackyk02 jackyk02 commented Apr 15, 2024

Problem:
When compiling carla_sync.lf which references include/carla_client.py, carla_client.py within the include folder has been deleted.

Solution:
This PR implements a temporary fix for the issue documented at lf-lang/lingua-franca#2203.

Related PRs:
lf-lang/rfcs#7
lf-lang/rfcs#8

@lhstrh lhstrh marked this pull request as ready for review April 15, 2024 20:07
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix, @jackyk02.

@lhstrh lhstrh merged commit 808c3c2 into lf-lang:main Apr 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants