-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for getting fully-qualified name in Cpp target #2431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please run ./gradlew spotlessApply
to fix the formatting test failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! While at it, I think it would be nice to add name()
as well.
The test currently only checks if fqn()
is available. It would be better to also assert the expected values.
|
Quick comment:
should become
|
… doesn't fall through the cracks
Cpp runtime has support for fully qualified name but is not available to reaction bodies. This PR adds support for fqn() in reactions.