Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for getting fully-qualified name in Cpp target #2431

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Conversation

OmerMajNition
Copy link
Collaborator

Cpp runtime has support for fully qualified name but is not available to reaction bodies. This PR adds support for fqn() in reactions.

@OmerMajNition OmerMajNition self-assigned this Oct 29, 2024
@lhstrh lhstrh requested a review from cmnrd October 29, 2024 20:20
@lhstrh lhstrh added the feature New feature label Oct 29, 2024
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run ./gradlew spotlessApply to fix the formatting test failure?

Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! While at it, I think it would be nice to add name() as well.

The test currently only checks if fqn() is available. It would be better to also assert the expected values.

@OmerMajNition
Copy link
Collaborator Author

OmerMajNition commented Oct 30, 2024

  • ./gradlew spotlessApply Done
  • Added name() support as well and validation in test file

@OmerMajNition
Copy link
Collaborator Author

OmerMajNition commented Oct 30, 2024

Quick comment:

reactor-cpp/lib/reactor.cc line # 50

[[maybe_unused]] bool result = inputs_.insert(port).second;

should become

[[maybe_unused]] bool result = outputs_.insert(port).second;

@lhstrh lhstrh changed the title Cpp fqn fix API for getting fully-qualified name in Cpp target Oct 31, 2024
@lhstrh lhstrh added the cpp Related to C++ target label Oct 31, 2024
@lhstrh lhstrh merged commit d65750a into master Oct 31, 2024
24 checks passed
@lhstrh lhstrh deleted the cpp_fqn_fix branch October 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ target feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants