Effects made accessible in watchdog handlers #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
commented
Jul 12, 2024
core/src/main/java/org/lflang/generator/c/CWatchdogGenerator.java
Outdated
Show resolved
Hide resolved
lhstrh
commented
Jul 12, 2024
lhstrh
added
enhancement
|
I've pushed support here for the diagrams, so that when a watchdog declares an action as an effect, we get this: 
|
lhstrh
commented
Jul 13, 2024
core/src/main/java/org/lflang/diagram/synthesis/util/ReactorIcons.java
Outdated
Show resolved
Hide resolved
edwardalee
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
I think this is ready to merge. Watchdogs still do not work with modes, but I've opened issue #2360.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar allows effects to be specified for a watchdog, but the compiler wasn't resolving effects correctly and the code generator needed to be updated to ensure that effects are brought into scope. This PR also updates the diagram synthesis to render watchdog effects correctly.