Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored highlighting of selected diagram edges #2324

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Conversation

soerendomroes
Copy link
Collaborator

This solution should be improved once the discussion in RFC 3 lf-lang/rfcs#3 completes.

@soerendomroes soerendomroes added the diagrams Problems with diagram synthesis label Jun 17, 2024
@soerendomroes soerendomroes requested review from lhstrh and cmnrd June 17, 2024 16:00
@lhstrh lhstrh added the feature New feature label Jun 17, 2024
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Considering that the highlighting isn't perfect (e.g. for ports) and we still have some discussion to do, would it be possible to make this configurable? E.g. by adding an option "Colored highlightling"?

@soerendomroes
Copy link
Collaborator Author

Thanks! Considering that the highlighting isn't perfect (e.g. for ports) and we still have some discussion to do, would it be possible to make this configurable? E.g. by adding an option "Colored highlightling"?

Could you add this idea to the rfc?

@cmnrd
Copy link
Collaborator

cmnrd commented Jul 2, 2024

I see this more as a step towards getting this PR merged without breaking anything, before we agree on a roadmap in the RFC. Think of it as a feature flag.

@lhstrh lhstrh requested a review from cmnrd August 2, 2024 19:30
@lhstrh lhstrh changed the title Added color to bold selection style. Colored highlighting of selected diagram edges Aug 4, 2024
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is ready to go?

@soerendomroes
Copy link
Collaborator Author

Looks like this is ready to go?

Yes, this is a very basic colorful selection highlighting that can be disabled if it is irritating.

@cmnrd cmnrd added this pull request to the merge queue Aug 16, 2024
Merged via the queue into master with commit 12cde59 Aug 16, 2024
26 checks passed
@cmnrd cmnrd deleted the sdo/selectionStyle branch August 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagrams Problems with diagram synthesis feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants