-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colored highlighting of selected diagram edges #2324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Considering that the highlighting isn't perfect (e.g. for ports) and we still have some discussion to do, would it be possible to make this configurable? E.g. by adding an option "Colored highlightling"?
Could you add this idea to the rfc? |
I see this more as a step towards getting this PR merged without breaking anything, before we agree on a roadmap in the RFC. Think of it as a feature flag. |
core/src/main/java/org/lflang/diagram/synthesis/LinguaFrancaSynthesis.java
Show resolved
Hide resolved
core/src/main/java/org/lflang/diagram/synthesis/styles/LinguaFrancaStyleExtensions.java
Show resolved
Hide resolved
core/src/main/java/org/lflang/diagram/synthesis/styles/LinguaFrancaStyleExtensions.java
Show resolved
Hide resolved
core/src/main/java/org/lflang/diagram/synthesis/styles/LinguaFrancaStyleExtensions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is ready to go?
Yes, this is a very basic colorful selection highlighting that can be disabled if it is irritating. |
This solution should be improved once the discussion in RFC 3 lf-lang/rfcs#3 completes.