Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed clean building federated programs #2247

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fixed clean building federated programs #2247

merged 1 commit into from
Mar 19, 2024

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Mar 19, 2024

Fixes #2171

@cmnrd cmnrd added the bugfix label Mar 19, 2024
@cmnrd cmnrd requested review from lhstrh and erlingrj March 19, 2024 10:10
lhstrh
lhstrh approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean solution to me! No pun intended..

@cmnrd cmnrd added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit fb4917b Mar 19, 2024
24 checks passed
@cmnrd cmnrd deleted the fed-clean branch March 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@erlingrj erlingrj Awaiting requested review from erlingrj

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Federated compilation with the clean flag does not work correctly
2 participants
@cmnrd @lhstrh