Added newline after trailing slash

[edwardalee]

This fixes a bug in the command to remotely launch an RTI by inserting a newline after the trailing slash.

There is still a problem, however, which is that ssh with a command does not source any bash profile files, so the PATH never gets set, so the RTI will likely not be found on the remote machine. The "right" fix, IMHO, is that we should code generate the RTI just like a federate and launch it just like a federate. But short of that, it would be better if FedLauncherGenerator created a bash script in a local file, then copied it to the remote machine and launched it there.

[vinzbarbuto]

That could fix the problem

[vinzbarbuto]

The bug is actually present on line 394. I suggest we replace "\n\" with "\n"\ as the sequence \" seems to be causing the error.

[lhstrh]

The bug is actually present on line 394. I suggest we replace "\n\" with "\n"\ as the sequence \" seems to be causing the error.

You're welcome to push a fix to this branch...

[vinzbarbuto]

Sure, Marten. I'll attend to it promptly. Il giorno ven 15 mar 2024 alle ore 18:51 Marten Lohstroh < ***@***.***> ha scritto:

…

The bug is actually present on line 394. I suggest we replace "\n\" with "\n"\ as the sequence \" seems to be causing the error. You're welcome to push a fix to this branch... — Reply to this email directly, view it on GitHub <#2245 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APBNLD3ZMBAZZ3L7ZJN7IYLYYOQQ3AVCNFSM6AAAAABEVC4PACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBRGA3DQNJTHE> . You are receiving this because your review was requested.Message ID: ***@***.***>

[vinzbarbuto]

Edward and Marten, prior to making any modifications, I conducted some tests, and it seems the code generator is now functioning correctly. It appears that the issue has been resolved in one of the previous commits. Therefore, I believe we can proceed to close the pull request.

[lhstrh]

I'm confused. Which version were you using when you reported the problem?

[vinzbarbuto]

I'm quite confused as well. Last week, it wasn't working, so I had to manually delete the \ separator. However, after the building phase, the issue I was facing seems to have vanished. My hunch is that I didn't update all the git submodules while dealing with the lfc-dev compiler

[lhstrh]

I never really understood the issue this was trying to solve, and the fix didn't look good to me. Should we just close this?

[edwardalee]

The issue this was trying to solve is that the script did not work if rtiLaunchString had a trailing backslash. However, the problem seems to have gone away, so I'm closing this.