Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for Docker #2234

Merged
merged 51 commits into from
Jun 19, 2024
Merged

Improved support for Docker #2234

merged 51 commits into from
Jun 19, 2024

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Mar 7, 2024

At times, it is necessary to run a command (e.g., to set environment variables) prior to building or when hitting the entry point. We add target properties to point to scripts for this purpose. We also add an option to skip the build step, in case integration into a more sophisticated build process is needed.

Related to #2232 in the sense that we need to check the handling across imported files etc.

@lhstrh lhstrh added the feature New feature label Mar 7, 2024
@lhstrh lhstrh changed the title Addition of pre-build-cmd to docker target property New pre-build-cmd option for docker target property Mar 7, 2024
@lhstrh lhstrh changed the title New pre-build-cmd option for docker target property New pre-build-script and run-script option for docker target property Apr 5, 2024
@lhstrh lhstrh changed the title New pre-build-script and run-script option for docker target property Improved support for Docker Jun 14, 2024
@lhstrh lhstrh marked this pull request as ready for review June 16, 2024 23:43
@lhstrh
Copy link
Member Author

lhstrh commented Jun 18, 2024

@a-sr: The Epoch build fails because I introduced a dependency. Could you please push a fix to epoch? This is the dependency: https://commons.apache.org/proper/commons-text/dependency-info.html

I made a start and tried lf-lang/epoch#74 but it doesn't seem to work

gradle.properties Outdated Show resolved Hide resolved
@lhstrh
Copy link
Member Author

lhstrh commented Jun 18, 2024

@a-sr: The Epoch build fails because I introduced a dependency. Could you please push a fix to epoch? This is the dependency: https://commons.apache.org/proper/commons-text/dependency-info.html

I made a start and tried lf-lang/epoch#74 but it doesn't seem to work

Thanks for coming to the rescue, @a-sr!

@lhstrh lhstrh removed the request for review from cmnrd June 18, 2024 17:45
@lhstrh lhstrh enabled auto-merge June 19, 2024 21:34
@lhstrh lhstrh added this pull request to the merge queue Jun 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 19, 2024
@lhstrh lhstrh merged commit 49c5f5d into master Jun 19, 2024
26 checks passed
@lhstrh lhstrh deleted the pre-build-cmd branch June 19, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants