Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of high-resolution counter device on Zephyr boards. Update to v3.4.0 #2007

Merged
merged 17 commits into from
Sep 16, 2023
Merged

Usage of high-resolution counter device on Zephyr boards. Update to v3.4.0 #2007

merged 17 commits into from
Sep 16, 2023

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Sep 14, 2023 •
edited
Loading

This PR does three things:

  1. Dont generate CMake code whiich looks for Threads library and links with it. Fails for certain Zephyr boards.
  2. Add a bunch of Device Tree Config overlays for different Zephyr boards to enable that we get high-resolution timers for these boards. The DTC overlays enable a timer device.
  3. Add a few tests for specific boards. Particularily, the boards on which we support the high-resolution timers. We just compile these simple programs to see that we indeed was able to enable a Timer device and get all the drivers etc. working.
  4. Move to Zephyr v3.4.0

@lhstrh
Copy link
Member

lhstrh commented Sep 14, 2023

Could you please provide a description? I have no idea what this does 😄

@erlingrj erlingrj changed the title Update nrf52 handling of the zephyr counter drivers Add more Zephyr board files to get the high-resolution Counter device as the system timer Sep 15, 2023
@erlingrj erlingrj changed the title Add more Zephyr board files to get the high-resolution Counter device as the system timer Add more Zephyr board files to get the high-resolution Counter device as the system timer. Add more integration tests Sep 15, 2023
@erlingrj
Copy link
Collaborator Author

@lhstrh yes! I also added some more fixes to this PR. Most importantly I added some test programs that we compile for specific boards, particularily those boards where we have support for "high-resolution timer", this support has caused some issues since it is not just using the Zephyr kernel API.

Next step would be buying a bunch of boards and also flashing them and seeing that they can accuratly toggle GPIOs.

lhstrh
lhstrh reviewed Sep 15, 2023
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
lhstrh
lhstrh requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Please revert the submodule protocol change and other than that this looks ready to merge...

core/src/main/resources/lib/platform/zephyr/boards/nrf52dk_nrf52832.overlay Outdated Show resolved Hide resolved
@lhstrh lhstrh changed the title Add more Zephyr board files to get the high-resolution Counter device as the system timer. Add more integration tests Usage of high-resolution counter device on Zephyr boards Sep 15, 2023
@lhstrh lhstrh added the feature New feature label Sep 15, 2023
@erlingrj erlingrj changed the title Usage of high-resolution counter device on Zephyr boards Usage of high-resolution counter device on Zephyr boards. Update to v3.4.0 Sep 16, 2023
@erlingrj erlingrj requested a review from lhstrh September 16, 2023 15:56
lhstrh
lhstrh approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting emphasis on testing! This looks great.

@lhstrh lhstrh added this pull request to the merge queue Sep 16, 2023
Merged via the queue into master with commit 089a32d Sep 16, 2023
41 checks passed
@lhstrh lhstrh deleted the update-nrf52-timers branch September 16, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @lhstrh