Merge pull request #2005 from lf-lang/spotbugs

Apply spotbugs plugin
lf-lang · Sep 14, 2023 · 30271bd · 30271bd
2 parents ddf67f3 + 9ea0a85
commit 30271bd
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 1 deletion.
diff --git a/buildSrc/build.gradle b/buildSrc/build.gradle
@@ -13,6 +13,8 @@ dependencies {
     // https://mvnrepository.com/artifact/com.diffplug.spotless/spotless-lib-extra
     implementation group: 'com.diffplug.spotless', name: 'spotless-lib-extra', version: spotlessLibVersion
 
+    implementation group: 'com.github.spotbugs.snom', name: 'spotbugs-gradle-plugin', version: spotbugsPluginVersion
+
     implementation "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
     implementation "com.diffplug.spotless:spotless-plugin-gradle:$spotlessVersion"
 

diff --git a/buildSrc/gradle.properties b/buildSrc/gradle.properties
@@ -2,4 +2,5 @@
 spotlessVersion=6.11.0
 spotlessLibVersion=2.30.0
 kotlinVersion=1.6.21
-shadowJarVersion=7.1.2
+shadowJarVersion=7.1.2
+spotbugsPluginVersion=5.1.3
diff --git a/buildSrc/src/main/groovy/org.lflang.java-conventions.gradle b/buildSrc/src/main/groovy/org.lflang.java-conventions.gradle
@@ -2,6 +2,7 @@ plugins {
     id 'java'
     id 'com.diffplug.spotless'
     id 'org.lflang.platform'
+    id 'com.github.spotbugs'
 }
 
 repositories {
@@ -19,6 +20,15 @@ spotless {
     }
 }
 
+spotbugs {
+    toolVersion = spotbugsToolVersion
+    excludeFilter.set(
+        rootProject.file('config/spotbugs/exclude.xml')
+    )
+    ignoreFailures = true
+}
+
+
 configurations.all {
     resolutionStrategy {
         dependencySubstitution {

diff --git a/config/spotbugs/exclude.xml b/config/spotbugs/exclude.xml
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+    <Match>
+        <Or>
+            <Package name="org.lflang.dsl*"/>
+            <Package name="org.lflang.parser.antlr"/>
+            <Package name="~org.lflang.parser.antlr\..*"/>
+            <Package name="org.lflang.lf"/>
+            <Package name="~org.lflang.lf\..*"/>
+            <Package name="org.lflang.services"/>
+            <Package name="~org.lflang.services\..*"/>
+            <Package name="org.lflang.serializer"/>
+            <Package name="~org.lflang.serializer\..*"/>
+            <Package name="org.lflang.ide.contentassist"/>
+            <Package name="~org.lflang.ide.contentassist\..*"/>
+            <Class name="org.lflang.ide.AbstractLFIdeModule"/>
+            <Class name="org.lflang.tests.LFInjectorProvider"/>
+        </Or>
+    </Match>
+</FindBugsFilter>
diff --git a/gradle.properties b/gradle.properties
@@ -21,6 +21,7 @@ xtextVersion=2.31.0
 klighdVersion=2.3.0.v20230606
 freehepVersion=2.4
 swtVersion=3.124.0
+spotbugsToolVersion=4.7.3
 
 [manifestPropertyNames]
 org.eclipse.xtext=xtextVersion