Add monitor application to EVE #4410

rucoder · 2024-10-31T14:58:44Z

This PR introduces a monitor agent to communicate with rust application that implements a TUI (TextUI) and allows the user to monitor system status and perform (as of now) two operaions:

Change IP address of Ethernet interface (DHCP <-> static)
Set server URL if the node is not yet onboarded

The monitor agent opens a Unix socket and waits for incoming connection. When the connection is established the NodeStatus structure is sent to the other party to provide current node status. Then other information is sent periodically as soon as it become available in PubSub

Current limitations/issues

network: yes is used in build.yaml while we are working on proper source vendoring approach for rust application
there is no way to completely remove manual DPC from the list
EVE structures should not be sent as-is to Rust. Every time the structure is changed on Eve side there is no way to catch this situation at build time. Stable EVE-Rust API is needed.
define git commit SHA in Dockerfile when Fix SetDPC request and implement SetServer request and UI eve-monitor-rs#3 is merged
write a documentation in pkg/pillar/docs/monitor.md

milan-zededa · 2024-10-31T15:19:27Z

pkg/pillar/cmd/nim/nim.go

+		AgentName:   "monitor",
+		MyAgentName: agentName,
+		TopicImpl:   types.DevicePortConfig{},
+		Persistent:  true,


This most likely does not need to be persistent since we persist currently known DPCs using pubDevicePortConfigList (i.e. in /persist/status/nim/DevicePortConfigList) - I assume this includes the manual DPC.

@milan-zededa yes, agree. I had this set to false for experements, but this change fall through the cracks.

codecov · 2024-10-31T15:20:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.93%. Comparing base (dd27fe1) to head (4734622).
Report is 20 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4410   +/-   ##
=======================================
  Coverage   20.93%   20.93%           
=======================================
  Files          13       13           
  Lines        2895     2895           
=======================================
  Hits          606      606           
  Misses       2163     2163           
  Partials      126      126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

milan-zededa · 2024-10-31T15:21:07Z

pkg/pillar/cmd/nim/nim.go

 	lastResort         *types.DevicePortConfig
+	manualDPC          *types.DevicePortConfig


It seems that forceManualDPC and manualDPC are unused?

@milan-zededa this was a placeholder to implement merging of DPCs, not it is done on rust side but I do not like to have so many dependencies on eve types. I'll remove it for now

milan-zededa · 2024-10-31T15:22:00Z

pkg/pillar/cmd/nim/nim.go

@@ -782,6 +809,12 @@ func (n *nim) handleDPCImpl(key string, configArg interface{}, fromFile bool) {
 		n.forceLastResort = false
 		n.reevaluateLastResortDPC()
 	}
+	// if device can connect to controller it may get a new DPC in global config. This global DPC
+	// will have higher priority but can be invalid and the device will loose connectifity again
+	// at least temporraraly while DPC is beeing tested. To avoid this we reset the timestamp on


temporraraly -> temporarily

(and connectifity in the line above)

milan-zededa · 2024-10-31T15:22:55Z

pkg/pillar/cmd/monitor/subsriptions.go

@@ -0,0 +1,444 @@
+// Copyright (c) 2024 Zededa, Inc.


Typo in the filename

OhmSpectator · 2024-10-31T15:34:29Z

pkg/monitor/Dockerfile

+RUN cp /app/target/$CARGO_BUILD_TARGET/release/monitor /app/target/
+
+
+FROM lfedge/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726 AS runtime


We use 591df01e581889c3027514c8a91feaca1c8ad49f now.

@OhmSpectator yeah, CI told me that. I'll fix.

christoph-zededa · 2024-10-31T16:02:18Z

pkg/pillar/cmd/monitor/messages.go

+	nodeStatus.ZedAgentStatus = ctx.getZedAgentStatus()
+	nodeStatus.AppSummary = ctx.getAppSummary()
+
+	if ctx.lastNodeStatus != nil && *ctx.lastNodeStatus == nodeStatus {


Is there a reason behind this check?

@christoph-zededa I have a plan to reuse this function to send a node stats to abstract types used in EVE from types used in Go-Rust interface

christoph-zededa · 2024-10-31T16:03:42Z

pkg/pillar/cmd/monitor/messages.go

+	if item, err := sub.Get("global"); err == nil {
+		zedAgentStatus := item.(types.ZedAgentStatus)
+		return zedAgentStatus
+	}


IMO the error should be logged

christoph-zededa · 2024-10-31T16:04:15Z

pkg/pillar/cmd/monitor/monitor.go

+var logger *logrus.Logger
+var log *base.LogObject
+
+type monitorContext struct {


Suggested change

type monitorContext struct {

type monitor struct {

It is not a context, is it?

@christoph-zededa we call the field in SubscriptionOptions Ctx aka context, and the type is typically "$agent"Context.

Sure, this is not the golang context.Context. But there is more than one kind of context; which one you refer to depends on your context ;-)

I would side with Christoph on this one, I think it is cleaner (and Go-Idiomatic) to just call it monitor. I haven't see this <something>Context terminology used with custom structs in any other Go project.

@eriknordmark @milan-zededa @christoph-zededa so, which one should I use? I have no personal preferences but as Erik mentioned we use this style all over EVE

NIM, zedrouter, mmagent and their components no longer use the Context suffix. I think it reads better and avoids confusion with context.Context

renamed to 'monitor'

christoph-zededa · 2024-10-31T16:05:12Z

pkg/pillar/cmd/monitor/monitor.go

+	if _, err := os.Stat(types.ServerFileName); os.IsNotExist(err) {
+		ctx.serverNameAndPort = ""
+		return nil
+	}


TOCTOU

better to just check if err from os.Readfile is an ENOENT

os.IsNotExist is the golang way to check this AFAIK.

https://pkg.go.dev/os#IsNotExist

This function predates errors.Is. It only supports errors returned by the os package. New code should use errors.Is(err, fs.ErrNotExist).

good that we talked about it :-)

christoph-zededa · 2024-10-31T16:07:12Z

pkg/pillar/cmd/monitor/monitor.go

+	findCmd := exec.Command("/sbin/findfs", "PARTLABEL=CONFIG")
+	deviceBytes, err := findCmd.Output()
+	if err != nil {
+		return fmt.Errorf("failed to find CONFIG partition: %v", err)


Suggested change

return fmt.Errorf("failed to find CONFIG partition: %v", err)

return fmt.Errorf("failed to find CONFIG partition: %v -- output was: %s", err, string(deviceBytes))

christoph-zededa · 2024-10-31T16:08:10Z

pkg/pillar/cmd/monitor/monitor.go

+	// 3. Mount the CONFIG partition as read-write
+	mountCmd := exec.Command("mount", "-t", "vfat", "-o", "rw,iocharset=iso8859-1", devicePath, tempDir)
+	if err := mountCmd.Run(); err != nil {
+		return fmt.Errorf("failed to mount CONFIG partition: %v", err)


please include the stdout/stderr of mount in the error message.

christoph-zededa · 2024-10-31T16:08:41Z

pkg/pillar/cmd/monitor/monitor.go

+	if err := mountCmd.Run(); err != nil {
+		return fmt.Errorf("failed to mount CONFIG partition: %v", err)
+	}
+	defer exec.Command("umount", tempDir).Run()


please check for errors

christoph-zededa · 2024-10-31T16:11:45Z

pkg/pillar/cmd/monitor/subsriptions.go

+			Ctx:           ctx,
+			CreateHandler: handleDPCCreate,
+			ModifyHandler: handleDPCModify,
+			DeleteHandler: handleDPCDelete,


Why does this one not have ErrorTime set?

christoph-zededa · 2024-10-31T16:12:59Z

pkg/pillar/cmd/monitor/subsriptions.go

+
+	subDevicePortConfigList, err := ps.NewSubscription(
+		pubsub.SubscriptionOptions{
+			AgentName:     "nim",
+			MyAgentName:   agentName,
+			Persistent:    true,
+			TopicImpl:     types.DevicePortConfigList{},
+			Activate:      false,
+			Ctx:           ctx,
+			CreateHandler: handleDPCCreate,
+			ModifyHandler: handleDPCModify,
+			DeleteHandler: handleDPCDelete,
+		})
+	if err != nil {
+		log.Error("Cannot create subscription for DevicePortConfigList")
+		return err
+	}
+
+	subAppInstanceSummary, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "zedmanager",
+		MyAgentName:   agentName,
+		TopicImpl:     types.AppInstanceSummary{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleAppInstanceSummaryCreate,
+		ModifyHandler: handleAppInstanceSummaryModify,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for AppInstanceSummary")
+		return err
+	}
+
+	subAppInstanceStatus, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "zedmanager",
+		MyAgentName:   agentName,
+		TopicImpl:     types.AppInstanceStatus{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleAppInstanceStatusCreate,
+		ModifyHandler: handleAppInstanceStatusModify,
+		DeleteHandler: handleAppInstanceStatusDelete,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for AppInstanceStatus")
+		return err
+	}
+
+	subDownloaderStatus, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "downloader",
+		MyAgentName:   agentName,
+		TopicImpl:     types.DownloaderStatus{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleDownloaderStatusCreate,
+		ModifyHandler: handleDownloaderStatusModify,
+		DeleteHandler: handleDownloaderStatusDelete,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for DownloaderStatus")
+		return err
+	}
+
+	subLedBlinkCounter, err := ps.NewSubscription(
+		pubsub.SubscriptionOptions{
+			AgentName:     "",
+			MyAgentName:   agentName,
+			TopicImpl:     types.LedBlinkCounter{},
+			Activate:      false,
+			Ctx:           ctx,
+			CreateHandler: handleLedBlinkCreate,
+			ModifyHandler: handleLedBlinkModify,
+			WarningTime:   warningTime,
+			ErrorTime:     errorTime,
+		})
+	if err != nil {
+		log.Error("Cannot create subscription for LedBlinkCounter")
+		return err
+	}
+
+	subZedAgentStatus, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "zedagent",
+		MyAgentName:   agentName,
+		TopicImpl:     types.ZedAgentStatus{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleZedAgentStatusCreate,
+		ModifyHandler: handleZedAgentStatusModify,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for ZedAgentStatus")
+		return err
+	}


christoph-zededa · 2024-10-31T16:17:11Z

pkg/pillar/cmd/monitor/ipc_server.go

+	clientConnected chan bool
+}
+
+// constructor


Suggested change

// constructor

// factory method

christoph-zededa · 2024-10-31T16:19:46Z

pkg/pillar/cmd/monitor/ipc_server.go

+		ipcMessage := IpcMessage{Type: t, Message: json.RawMessage(data)}
+		if data, err = json.Marshal(ipcMessage); err == nil {
+			log.Noticef("Sending IPC message: %s", string(data))
+			_, err = s.codec.Write(data)


please wrap the error so that the reader of the log can see later which function the error came from

christoph-zededa · 2024-10-31T16:21:53Z

pkg/pillar/cmd/monitor/ipc_server.go

+		if err := json.Unmarshal(r.RequestData, &dpc); err == nil {
+			if err := ctx.IPCServer.validateDPC(dpc); err != nil {
+				return r.errResponse("Failed to validate DPC", err)
+			}
+			// unpublish current manual DPC first
+			ctx.pubDevicePortConfig.Unpublish(dpc.Key)
+			// publish the DPC
+			if err := ctx.pubDevicePortConfig.Publish(dpc.Key, dpc); err != nil {
+				return r.errResponse("Failed to publish DPC", err)
+			} else {
+				return r.okResponse()
+			}
+		} else {
+			return r.malformedRequestResponse(err)
+		}
+	case "SetServer":
+		var server string
+		if err := json.Unmarshal(r.RequestData, &server); err == nil {
+			if err := ctx.updateServerFile(server); err != nil {
+				return r.errResponse("Failed to update server file", err)
+			} else {
+				return r.okResponse()
+			}
+		} else {
+			return r.malformedRequestResponse(err)
+		}


sometimes you check if err != nil and then have an else case, sometimes you check if err == nil and then have an else case

@christoph-zededa why is this bad?

I am just wondering what is the reason behind it.

The "bad" thing is that it is deeply nested.

Suggested change

if err := json.Unmarshal(r.RequestData, &dpc); err == nil {

if err := ctx.IPCServer.validateDPC(dpc); err != nil {

return r.errResponse("Failed to validate DPC", err)

}

// unpublish current manual DPC first

ctx.pubDevicePortConfig.Unpublish(dpc.Key)

// publish the DPC

if err := ctx.pubDevicePortConfig.Publish(dpc.Key, dpc); err != nil {

return r.errResponse("Failed to publish DPC", err)

} else {

return r.okResponse()

}

} else {

return r.malformedRequestResponse(err)

}

case "SetServer":

var server string

if err := json.Unmarshal(r.RequestData, &server); err == nil {

if err := ctx.updateServerFile(server); err != nil {

return r.errResponse("Failed to update server file", err)

} else {

return r.okResponse()

}

} else {

return r.malformedRequestResponse(err)

}

if err := json.Unmarshal(r.RequestData, &dpc); err != nil {

return r.malformedRequestResponse(err)

}

if err := ctx.IPCServer.validateDPC(dpc); err != nil {

return r.errResponse("Failed to validate DPC", err)

}

// unpublish current manual DPC first

ctx.pubDevicePortConfig.Unpublish(dpc.Key)

// publish the DPC

if err := ctx.pubDevicePortConfig.Publish(dpc.Key, dpc); err != nil {

return r.errResponse("Failed to publish DPC", err)

}

return r.okResponse()

case "SetServer":

var server string

if err := json.Unmarshal(r.RequestData, &server); err != nil {

return r.malformedRequestResponse(err)

}

if err := ctx.updateServerFile(server); err != nil {

return r.errResponse("Failed to update server file", err)

}

return r.okResponse()

christoph-zededa · 2024-10-31T16:22:59Z

pkg/pillar/cmd/monitor/ipc_server.go

+			log.Notice("Accepted connection")
+
+			if err != nil {
+				log.Warnf("Accept for RPC call failed: %v", err)
+				continue
+			}


Suggested change

log.Notice("Accepted connection")

if err != nil {

log.Warnf("Accept for RPC call failed: %v", err)

continue

}

if err != nil {

log.Warnf("Accept for RPC call failed: %v", err)

continue

}

log.Notice("Accepted connection")

eriknordmark

It would be good to add a markdown file in pkg/pillar/docs/monitor.md which describes the relationship between the code inside pillar/zedbox and the rust code.

christoph-zededa · 2024-10-31T16:49:27Z

pkg/monitor/Dockerfile

+
+# building the final image
+FROM toolchain AS builder
+ADD --keep-git-dir=true https://github.com/lf-edge/eve-monitor-rs.git /app


Did somebody review this code?

Not the entire code, but there is at least one PR to be reviewed: lf-edge/eve-monitor-rs#3

Before this commit PCR indexes were present only in error text. Add them to VaultStatus to simplify further analysis Signed-off-by: Mikhail Malyshev <[email protected]>

christoph-zededa · 2024-10-31T23:13:22Z

pkg/pillar/cmd/monitor/monitor.go

+	if err != nil {
+		return fmt.Errorf("failed to find CONFIG partition: %v", err)
+	}
+	devicePath := strings.TrimSpace(string(deviceBytes))


Suggested change

devicePath := strings.TrimSpace(string(deviceBytes))

devicePath := strings.TrimRight(string(deviceBytes), "\n\r")

shjala · 2024-11-04T10:46:03Z

pkg/monitor/build.yml

+    - /containers:/containers:rshared,rbind
+
+  devices:
+    # all block devices


Do you really need all these?

shjala · 2024-11-04T10:46:32Z

pkg/monitor/build.yml

+network: yes
+config:
+  pid: host
+  binds:


same question here, is all these access needed?

@shjala probably not.

could you go through them, pick the ones you really need and add a comment above each one that is needed stating why it is needed? it makes creating apparmor profile much easier.

same for this.

shjala · 2024-11-04T10:47:31Z

@rucoder let's cook an apparmor profile for it while it is being introduced.

rucoder · 2024-11-06T13:34:19Z

@rucoder let's cook an apparmor profile for it while it is being introduced.
@shjala let's cook it in a separate PR then. I'll create a ticket

rene · 2024-11-11T09:47:40Z

pkg/monitor/Dockerfile

+COPY --from=runtime /out/usr/lib /usr/lib
+
+# copy busybox and sh but just for debugging
+COPY --from=runtime /out/bin/sh /bin/sh


in this case, /bin/sh will be a symbolic link to busybox, right? So instead of copy both sh and busybox (line below), it makes sense to copy only busybox and run /bin/busybox --install -s <DESTINATION_DIR> to create all symbolic links of supported commands...

@rene your suggestion will not work as-is but I implemented a similar one. check out updated code. pretty interesting fact

rene · 2024-11-11T10:04:22Z

pkg/pillar/agentlog/agentlog.go

@@ -289,7 +289,7 @@ func RebootReason(reason string, bootReason types.BootReason, agentName string,
 	}

 	// Printing the reboot reason to the console
-	filename = "/dev/console"


Some scripts from pkg/pillar/scripts also write to /dev/console, doesn't make sense to change them as well?

@rene I checked those and they do not affect monitor app. They actually should write to console so we see the output on /dev/ttyS* if connected. Monitor is started after they finish so it should be ok. I still need to modify getty to properly handle console devices anyways

- The monitor agent establishes a connection over Unix socket and send messages to rust application about the system state. - It handles two requests: SetDPC to set new configuration for networking interfaces and SetServer to change the contents of /config/server file Signed-off-by: Mikhail Malyshev <[email protected]>

- the monitor agent depends on a module to parse binary stream from Unix socket in predefined format Signed-off-by: Mikhail Malyshev <[email protected]>

rucoder · 2024-11-21T15:50:59Z

@rucoder let's cook an apparmor profile for it while it is being introduced.
@shjala let's cook it in a separate PR then. I'll create a ticket

ok, I fixed that (mostly)

- The application itself is hosted at https://github.com/lf-edge/eve-monitor-rs - The container is built using lfedge/eve-rust:1.80.1 base image and uses cross-compilation - RISCV target is not yet supported - cargo-chef is used to speedup development. It won't speedup CI when --no-cache is used for building - SBOM is generated using cargo-sbom Brief design description 1. The container is started on /dev/tty3 using openvt and not started on any other consoles including SSH and serial consoles. It is intended to be used only by a local operator 2. Full dmesg output is disabled and only panic output is enabled. Full dmesg output is available in the application 3. Standard keymap is changed to support CTRL+left|right|up|down key combinations Signed-off-by: Mikhail Malyshev <[email protected]>

/dev/console ins the current console for kernel so even when we switch to /dev/tty3 messages still appear and corrupt monitor application. Fo now print them on /dev/tty which is the default kernel tty. TODO: 1. diag output must appear on /dev/ttyS* if defined in the list of kernel consoles 2. The same applies to other subsystems In order to do so the kernel command line must be parsed and the last console= must be detected. Unfortunately there is no easier way to do this Signed-off-by: Mikhail Malyshev <[email protected]>

- 'manual' DPC has highest priority and applied immediately - there can be only one 'manual' DPC. so we nedd to delete all backup copies of it from a DPC list. EVE should not care about previous attempts to change network configuration Signed-off-by: Mikhail Malyshev <[email protected]>

- monitor app is run only on physical monitor so we need to run QEMU with -vga or similar to see it Signed-off-by: Mikhail Malyshev <[email protected]>

- Setting server URL in both /config/server and real config partition Signed-off-by: Mikhail Malyshev <[email protected]>

- Add comments for SubscriptionOptions.{WarningTime, ErrorTime} fields Signed-off-by: Mikhail Malyshev <[email protected]>

- add documentation for pkg/monitor container - update NIM documentation - add documentation for pkg/pillar/cmd/monitor service Signed-off-by: Mikhail Malyshev <[email protected]>

rucoder requested review from deitch, milan-zededa and eriknordmark as code owners October 31, 2024 14:58

github-actions bot requested review from jsfakian and shjala October 31, 2024 14:59

milan-zededa reviewed Oct 31, 2024

View reviewed changes

OhmSpectator reviewed Oct 31, 2024

View reviewed changes

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

rucoder force-pushed the rucoder/monitor-agent branch from 4734622 to 0aa91aa Compare October 31, 2024 16:09

github-actions bot requested a review from milan-zededa October 31, 2024 16:09

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

eriknordmark reviewed Oct 31, 2024

View reviewed changes

rucoder force-pushed the rucoder/monitor-agent branch from 0aa91aa to 8fb1a58 Compare October 31, 2024 16:35

github-actions bot requested a review from eriknordmark October 31, 2024 16:36

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

Add mismatching PCR indexes to VaultStatus

ae0e6bd

Before this commit PCR indexes were present only in error text. Add them to VaultStatus to simplify further analysis Signed-off-by: Mikhail Malyshev <[email protected]>

rucoder force-pushed the rucoder/monitor-agent branch from 8fb1a58 to d6c813e Compare October 31, 2024 17:19

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

shjala reviewed Nov 4, 2024

View reviewed changes

rene reviewed Nov 11, 2024

View reviewed changes

rucoder added 2 commits November 20, 2024 16:44

Vendor required modules for monitor agent

bc956e9

- the monitor agent depends on a module to parse binary stream from Unix socket in predefined format Signed-off-by: Mikhail Malyshev <[email protected]>

rucoder force-pushed the rucoder/monitor-agent branch from d6c813e to ec80f21 Compare November 20, 2024 15:56

github-actions bot requested a review from shjala November 20, 2024 15:57

rucoder force-pushed the rucoder/monitor-agent branch from 54254ff to e4ec643 Compare November 21, 2024 12:21

rucoder added 7 commits November 21, 2024 16:52

Add run-live-gui target to run monitor container

b520194

- monitor app is run only on physical monitor so we need to run QEMU with -vga or similar to see it Signed-off-by: Mikhail Malyshev <[email protected]>

Handle SetServer request

3902042

- Setting server URL in both /config/server and real config partition Signed-off-by: Mikhail Malyshev <[email protected]>

Add some comments to PubSub

7a513f6

- Add comments for SubscriptionOptions.{WarningTime, ErrorTime} fields Signed-off-by: Mikhail Malyshev <[email protected]>

Add documentation for monitor TUI application

95a773c

- add documentation for pkg/monitor container - update NIM documentation - add documentation for pkg/pillar/cmd/monitor service Signed-off-by: Mikhail Malyshev <[email protected]>

rucoder force-pushed the rucoder/monitor-agent branch from e4ec643 to 95a773c Compare November 21, 2024 15:52

		lastResort *types.DevicePortConfig
		manualDPC *types.DevicePortConfig

		RUN cp /app/target/$CARGO_BUILD_TARGET/release/monitor /app/target/


		FROM lfedge/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726 AS runtime

	return fmt.Errorf("failed to find CONFIG partition: %v", err)
	return fmt.Errorf("failed to find CONFIG partition: %v -- output was: %s", err, string(deviceBytes))

	devicePath := strings.TrimSpace(string(deviceBytes))
	devicePath := strings.TrimRight(string(deviceBytes), "\n\r")

Add monitor application to EVE #4410

Are you sure you want to change the base?

Add monitor application to EVE #4410

Conversation

rucoder commented Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 31, 2024

Codecov Report

milan-zededa Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milan-zededa Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milan-zededa Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eriknordmark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shjala commented Nov 4, 2024

rucoder commented Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rene Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rucoder commented Nov 21, 2024

rucoder commented Oct 31, 2024 •

edited

Loading

milan-zededa Oct 31, 2024 •

edited

Loading

milan-zededa Oct 31, 2024 •

edited

Loading

milan-zededa Oct 31, 2024 •

edited

Loading

rucoder commented Nov 6, 2024 •

edited

Loading

rene Nov 11, 2024 •

edited

Loading