Set default build target for native builds #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
reviewed
Aug 23, 2024
Dockerfile
Outdated
| RUN rustup default $RUST_VERSION-riscv64gc-unknown-linux-gnu | ||
| ENV CARGO_BUILD_TARGET="riscv64gc-unknown-linux-gnu" | ||
|
|
||
| FROM tools-target-$TARGETARCH AS tools-trget |
There was a problem hiding this comment.
This should be tools-target (typo)
There was a problem hiding this comment.
This should be
tools-target(typo)
yep, I'll fix in the next push
rucoder
force-pushed
the
rucoder/fix-native-targets
branch
from
7d65fc0
to
6e467b4
Compare
|
Fixes #8 |
|
I can confirm that this resolves our build issues. As long as |
Signed-off-by: Mikhail Malyshev <[email protected]>
Signed-off-by: Mikhail Malyshev <[email protected]>
rucoder
force-pushed
the
rucoder/fix-native-targets
branch
from
6e467b4
to
2b63002
Compare
deitch
approved these changes
Aug 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARGO_BUILD_TARGET must be always set since we are not building for default
-unknown-linug-gnutriplet