-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update groups reg to be under event url #716
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update refines the routing structure in the application by nesting the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/berlin/src/App.tsx (2 hunks)
Additional comments not posted (1)
packages/berlin/src/App.tsx (1)
250-257
: Verify the correctness of the new routing structure.The new routing structure nests the
/secret-groups
and/public-groups
routes under a dynamic:eventId
parameter. Ensure that the navigation remains consistent and relevant to the context of the event.
overview
the reason behind this is to fix that when i click groups the navbar would have changed to the global links and not the event links.
Summary by CodeRabbit
SecretGroupRegistration
andPublicGroupRegistration
to be accessed via:eventId/secret-groups
and:eventId/public-groups
.