644 bring shadcn to develop #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
camilovegag
added
improvement
Closed
|
lets redo this because i think edge-esmeralda might be wrong in some ways as all the dependencies seem to be needed in production but according to these docs they can be dev dependencies: https://ui.shadcn.com/docs/installation/vite |
diegoalzate
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #644
Adds tailwind and capability to use shadcn components in develop branch.
This is based on edge esmeralda branch files, added react types to berlin package because shadcn components were warning about:
The inferred type cannot be named without a reference to '.pnpm/@[email protected]/node_modules/@types/react'. This is likely not portable. A type annotation is necessary.ts(2742)