Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

559 change secret to access code at table #560

Merged
merged 8 commits into from
May 24, 2024

Conversation

camilovegag
Copy link
Collaborator

@camilovegag camilovegag commented May 24, 2024

Closes: #559

This pr also fixes an awkward space at header and the icon size

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
core ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 4:26pm
forum-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 4:26pm

@camilovegag camilovegag merged commit 1f3522e into develop May 24, 2024
5 checks passed
@camilovegag camilovegag deleted the 559-change-secret-to-access-code-at-table branch May 24, 2024 17:38
camilovegag added a commit that referenced this pull request May 28, 2024
* Update back button to recieve a fallback route

* Create a loader to redirect to cycle id if cycle is open (protect /results)

* Add fallback route to cycle back button

* 561 redirect to results when cycle closes (#562)

* Match nav distribution from desktop on mobile

* Redirect to results if cycle is closed

* Add refetch of 5 seconds to cycle

* Change redirect to navigate

* Add toast

* Add fallback route to results page back button

* Show toast with clock emoji

* Update message

* Remove emoji

* fix joining public groups

* 559 change secret to access code at table (#560)

* Change secret to access code at group table

* Hide input number arrows

* Hide spinner at hover

* Fix header ui

* Remove type number input styles as they dont work as expected

* Burning min of 0 and max of 10000 for input fields (funding at the moment)

* Burn a 0 to 10000 validation at number input

* Update min and max checks

* Make public group registration more general (#565)

* Fix query key

* Update min number input value from 0 to 250 & validation messages (#568)

* Fix nav links on mobile (#566)

* 569 update secret groups page (#570)

* Update copy

* Update layout

* Update final question constant (#572)

* Minor fixes (#573)

* Fix long usernames at comments table

* sort by lead if votes are equal

* sort by id if votes are equal

* add sort fallback by id

---------

Co-authored-by: Diego Alzate <[email protected]>

* 574 swap usernames to full names on comments page (#575)

* Change group names to voter affiliations

* Update comments response type

* Show full name instead of username

---------

Co-authored-by: Diego Alzate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change secret to access code at table
2 participants