Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trigger validation on submit #149

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix trigger validation on submit #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4fea25
fix validation
MartinBenediktBusch Feb 8, 2024
a005889
simpliefied code
MartinBenediktBusch Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/berlin/src/pages/Account.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ function AccountForm({
});

const onSubmit = (value: typeof initialUser) => {
if (user && user.id) {
if (isValid && user && user.id) {
mutateUserData({
userId: user.id,
username: value.username,
Expand Down Expand Up @@ -381,9 +381,7 @@ function AccountForm({
icon={{ src: `/icons/add-${theme}.svg`, alt: 'Add icon' }}
/>
</FlexColumn>
<Button type="submit" disabled={!isValid}>
Submit
</Button>
<Button type="submit">Submit</Button>
</FlexColumn>
</form>
</FlexColumn>
Expand Down
Loading