-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement format and linting ci/cd #148
Merged
MartinBenediktBusch
merged 14 commits into
develop
from
120-replicate-backend-linter-and-format-requirements
Feb 8, 2024
Merged
Implement format and linting ci/cd #148
MartinBenediktBusch
merged 14 commits into
develop
from
120-replicate-backend-linter-and-format-requirements
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MartinBenediktBusch
changed the title
implement format and linting ci/cd
Implement format and linting ci/cd
Feb 7, 2024
diegoalzate
reviewed
Feb 7, 2024
diegoalzate
suggested changes
Feb 7, 2024
diegoalzate
approved these changes
Feb 8, 2024
MartinBenediktBusch
deleted the
120-replicate-backend-linter-and-format-requirements
branch
February 8, 2024 15:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses the issue titled "Replicate the backend linter and format requirements in the frontend to ensure a minimum level of code consistency. Furthermore, implement .github/workflows for formatting and linting to have it checked at each commit."
Changes Made:
Linting and Formatting Setup:
.eslintrc.cjs
configuration file to define linting rules using the@typescript-eslint
plugin.@typescript-eslint/no-explicit-any
and@typescript-eslint/no-var-requires
as required.GitHub Workflow Setup:
check-formatting.yaml
andlint.yaml
to check code formatting and linting on each commit.pnpm format
(pnpm lint) command to ensure code adheres to formatting standards defined by Prettier.develop
andmain
branches to catch formatting issues before merging.Fixed Linting and Formatting: