-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient bot changes #20
Open
GotEmCoach
wants to merge
11
commits into
lewisgibson:main
Choose a base branch
from
GotEmCoach:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated main.py to handle errors without crashing. - errors are reported on screen. Specifically when an image could not be located with sufficient confidence - retook a ton of screenshots to help with the collection - warning - shutdown screenshots can sometimes trigger clicks in the wrong areas on the main view. Adjust those screenshots to your liking. - added .5 second sleep after successful image finds - added more console prompts to inform whats happening
- Windows 10/11 compatible only - Not Mac tested yet - no longer needs powershell to achieve elevated permissions - must use a powershell terminal in order to run - added a variable to pick specific window by name - all dependencies updated in requirements - added a script to auto update the dependencies versioning in requirements.txt based on the currently installed versions. Only use this if the dependencies are working in their current version and it is listed in the requirements already. - adjust readme to point out using the python command rather than running start.ps1. Powershell terminal is still required but it uses only 1 script now. - added more screenshots to improve image finding
…close different emulators
LutherXoxo
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not completely finished but wanted to get the PR up for others