Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt post-check message to context #13

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Adapt post-check message to context #13

wants to merge 10 commits into from

Conversation

Eschults
Copy link
Member

@Eschults Eschults commented Oct 3, 2024 •
edited
Loading

This PR aims at publishing a new 0.1.1 version of the package where we can set the post check output message w/ an NBRESULT_POST_CHECK_MESSAGE environment variable, to avoid having to pip install using the Github repo on a specific branch cf https://github.com/lewagon/data-analytics-with-python/commit/05323dc893e4c8eca7834bb5e50252111b41171c 👌

@Eschults Eschults changed the title Airliquide Adapt post-check message to context Oct 3, 2024
@Eschults Eschults requested a review from ssaunier October 3, 2024 09:49
ssaunier
ssaunier reviewed Oct 3, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
ssaunier
ssaunier approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ssaunier ssaunier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssaunier ssaunier ssaunier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eschults @ssaunier @olivergiles