Skip to content

Commit

Permalink
Bump nbresult to 0.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
ssaunier committed Apr 5, 2024
1 parent 883a6f3 commit 68b45b6
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 60 deletions.
42 changes: 0 additions & 42 deletions .github/workflows/ghcr_build_latest_on_push.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/ghcr_publish_on_release_tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
- name: Cache Docker layers
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: /tmp/.buildx-cache
key: ${{ runner.os }}-buildx-${{ github.sha }}
Expand Down
20 changes: 5 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,14 @@

# release

- create `py-${PYTHON_VERSION}-${YEAR}-${QUARTER}` branch
- update `Dockerfile` source image python version
- update `requirements.txt` from [data-setup specs/releases/glovebox.txt](https://github.com/lewagon/data-setup/blob/master/specs/releases/glovebox.txt)
- push branch
- update `Dockerfile` source image python version / `requirements.txt`
- make sure it builds
- TODO update `requirements.txt` from [data-setup specs/releases/glovebox.txt](https://github.com/lewagon/data-setup/blob/master/specs/releases/glovebox.txt)
- create tag / push commit
- draft a `release` (which triggers the `ghcr_publish_on_release_tag` GHA)
- update `data-solutions` glovebox image
- update `active_admin` programs to use the image

## draft a `release`

[draft a new release](https://github.com/lewagon/data-runner/releases):
- choose a tag: use `${BRANCH_NAME}-v1` (ignore branch/tag naming confusion warning) / create
- choose a target: use `${BRANCH_NAME}`
- release title: use `${BRANCH_NAME}-v1`
- description: ...
- publish release

list container images:

``` bash
Expand All @@ -26,7 +17,7 @@ gh release list --repo lewagon/data-runner

## update `data-solutions` glovebox image

[edit data-solutions/test-solutions-action/Dockerfile](https://github.com/lewagon/data-solutions/blob/master/test-solutions-action/Dockerfile):
TODO [edit data-solutions/test-solutions-action/Dockerfile](https://github.com/lewagon/data-solutions/blob/master/test-solutions-action/Dockerfile):
- replace `FROM ghcr.io/lewagon/data-runner:$TAG_NAME`

## update `active_admin` programs to use the image
Expand Down Expand Up @@ -54,7 +45,6 @@ gh release list --repo lewagon/data-runner

``` bash
.github/workflows/ghcr_publish_on_release_tag.yml # publication GHA
.github/workflows/ghcr_build_latest_on_push.yml # unused ? (no push/merge on master)
```

# source
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ matplotlib==3.5.3
matplotlib-inline==0.1.6
mccabe==0.6.1
memoized-property==1.0.3
nbresult==0.0.8
nbresult==0.1.0
numpy==1.23.4
packaging==21.3
pandas==1.4.4
Expand All @@ -49,7 +49,7 @@ pyparsing==3.0.9
pytest==7.1.3
python-dateutil==2.8.2
pytz==2022.1
PyYAML==5.4.1
PyYAML==6.0.1
requests==2.28.1
scikit-learn==1.1.2
scipy==1.8.1
Expand Down

0 comments on commit 68b45b6

Please sign in to comment.