Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker compose file example in README.md #475

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix docker compose file example in README.md #475

merged 1 commit into from
Oct 21, 2024

Commits on Oct 16, 2024

  1. Fix(NOISSUE): Fix docker compose file example in README.md 

    In README.md is an example docker-compose.yaml file that can be improved
in two points

- The "version" top level element is obsolete, see
  https://docs.docker.com/reference/compose-file/version-and-name/
- The "command" element contains a superflous "pebble" that prevents the
  following parameters from being parsed. (In the included
  docker-compose.yaml, the "command" element is already correct, see
  https://github.com/letsencrypt/pebble/blob/e08dd94e723a0e8d005d7c6149a8666e4bf5d877/docker-compose.yml#L5
  for comparison.)
    @FalkoFlessner
    FalkoFlessner committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    54f2840 View commit details
    Browse the repository at this point in the history