Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wfe: Handle empty JSON to /acme/acct like POST-as-GET #7844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wfe: Handle empty JSON to /acme/acct like POST-as-GET #7844

wants to merge 1 commit into from

Commits on Nov 23, 2024

  1. wfe: Handle empty JSON to /acct like POST-as-GET 

    ACME clients can make an empty request to /acme/acct for their reg object. wfe.Account handles a truly empty request correctly, but has routed empty JSON objects to updateAccount, even though an update is not appropriate. This only happened to work because UpdateRegistration's impl takes an entire Registration and returns it even if unchanged.

This preserves ACMEv1 backwards compatibility when UpdateRegistration is simplified.
    @jprenken
    jprenken committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e132ca0 View commit details
    Browse the repository at this point in the history