Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFE/nonce: Remove deprecated NoncePrefixKey field #7825

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WFE/nonce: Remove deprecated NoncePrefixKey field #7825

wants to merge 2 commits into from

Conversation

jprenken
Copy link
Contributor

Remove the deprecated WFE & nonce config field NoncePrefixKey, which has been replaced by NonceHMACKey.

DO NOT MERGE until:

Fixes #7632

@jprenken
WFE/nonce: Remove deprecated NoncePrefixKey field
ff6c22d 
Remove the deprecated WFE & nonce config field `NoncePrefixKey`, which has been replaced by `NonceHMACKey`.

DO NOT MERGE until:
- #7793 (in `release-2024-11-18`) has been deployed, AND:
- `NoncePrefixKey` has been removed from all running configs.

Fixes #7632
@jprenken jprenken requested a review from a team as a code owner November 19, 2024 05:31
beautifulentropy
beautifulentropy requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some small nits on my part.

cmd/boulder-wfe2/main.go Outdated Show resolved Hide resolved
cmd/nonce-service/main.go Outdated Show resolved Hide resolved
aarongable
aarongable approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoncePrefixKey has been removed from all running configs.

Do we have an IN- ticket for this?

@jprenken
Copy link
Contributor Author

Do we have an IN- ticket for this?

Yes, this is IN-10809.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beautifulentropy beautifulentropy beautifulentropy approved these changes

@aarongable aarongable aarongable approved these changes

@jsha jsha Awaiting requested review from jsha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jprenken @aarongable @beautifulentropy