Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "CRLDPBase" config item optional #7427

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Apr 10, 2024

This was missed in #7300

Part of #7296
IN-10046 tracks the corresponding production config change.

@aarongable aarongable requested a review from a team as a code owner April 10, 2024 16:43
@mcpherrinm
Copy link
Contributor

Should this update a config in test/config or test/config-next to make sure we're testing a config aligning with our production one?

@aarongable
Copy link
Contributor Author

Should this update a config in test/config or test/config-next to make sure we're testing a config aligning with our production one?

Yep, that just hadn't happened yet because I made this in the github UI and that only lets you edit one file at a time.

@mcpherrinm
Copy link
Contributor

Great, thank you!

@pgporada pgporada requested review from a team and beautifulentropy and removed request for a team April 10, 2024 17:34
@aarongable aarongable merged commit ce8986e into main Apr 12, 2024
14 checks passed
@aarongable aarongable deleted the crldpbase-deprecation branch April 12, 2024 18:23
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
AlinaADmi pushed a commit to plesk/boulder that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants