RA: Count failed authorizations using key-value rate limits #7346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
ratelimits-ra-failed-validations
branch
3 times, most recently
from
5d9ac4c
to
ae68d7c
Compare
beautifulentropy
force-pushed
the
ratelimits-ra-failed-validations
branch
from
ae68d7c
to
57bac16
Compare
pgporada
requested changes
Mar 1, 2024
pgporada
previously approved these changes
Mar 1, 2024
pgporada
force-pushed
the
ratelimits-ra-failed-validations
branch
from
65bac94
to
57bac16
Compare
aarongable
requested changes
Mar 6, 2024
beautifulentropy
added a commit
that referenced
this pull request
Mar 6, 2024
…7344) - Update the failed authorizations limit to use 'enum:regId:domain' for transactions while maintaining 'enum:regId' for overrides. - Modify the failed authorizations transaction builder to generate a transaction for each order name. - Rename the `FailedAuthorizationsPerAccount` enum to `FailedAuthorizationsPerDomainPerAccount` to align with its corrected implementation. This change is possible because the limit isn't yet deployed in staging or production. Blocks #7346 Part of #5545
beautifulentropy
force-pushed
the
ratelimits-ra-failed-validations
branch
from
40cd858
to
a0dc3a7
Compare
aarongable
approved these changes
Mar 6, 2024
pgporada
approved these changes
Mar 11, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5545