WFE: Check NewOrder rate limits #7201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
commented
Dec 8, 2023
|
@beautifulentropy, this PR appears to contain configuration changes. Please ensure that a corresponding deployment ticket has been filed with the new configuration values. |
beautifulentropy
force-pushed
the
ratelimits-new-order
branch
from
70590e2
to
fcb227c
Compare
18 tasks
|
Added some TODOs and moved this back to draft until I get those done. |
beautifulentropy
force-pushed
the
ratelimits-new-order
branch
from
8aa9c0f
to
3609d28
Compare
beautifulentropy
force-pushed
the
ratelimits-new-order
branch
from
54744d1
to
3c1f7a9
Compare
aarongable
reviewed
Jan 12, 2024
aarongable
reviewed
Jan 17, 2024
beautifulentropy
force-pushed
the
ratelimits-new-order
branch
from
9756c68
to
ffcdcb1
Compare
beautifulentropy
added a commit
that referenced
this pull request
Jan 17, 2024
Update RA and CA configuration to be more consistent with the identical MaxNames field added to the WFE by #7201.
aarongable
approved these changes
Jan 17, 2024
| var newOrderSuccessful bool | ||
| var errIsRateLimit bool | ||
| defer func() { | ||
| if !newOrderSuccessful && !errIsRateLimit { |
There was a problem hiding this comment.
Same comment here as on the other PR
pgporada
approved these changes
Jan 26, 2024
| }, | ||
| LookupDNSAuthority: "consul.service.consul", | ||
| } | ||
| rc.PasswordConfig = cmd.PasswordConfig{ |
There was a problem hiding this comment.
Nit: You could include the PasswordConfig in the bredis.Config above.
LookupDNSAuthority: "consul.service.consul",
PasswordConfig: cmd.PasswordConfig{
PasswordFile: "test/secrets/ratelimits_redis_password",
},
}
| // defaults to 100. These limits are per section 7.1 of our combined | ||
| // CP/CPS, under "DV-SSL Subscriber Certificate". The value must match | ||
| // the CA and RA configurations. | ||
| MaxNames int `validate:"min=0,max=100"` |
There was a problem hiding this comment.
Nit: I understand that the validation tag catches this, but MaxNames could be declared as a uint instead. A minor type changes would be needed in the NewWebFrontEndImpl constructor and WebFrontEndImpl struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add non-blocking checks of New Order limits to the WFE using the new key-value based rate limits package.
Part of #5545