Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RA: Fix legacy override utilization metrics #7124

Merged
merged 6 commits into from
Nov 20, 2023
Merged

RA: Fix legacy override utilization metrics #7124

merged 6 commits into from
Nov 20, 2023

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Oct 30, 2023 •
edited
Loading

  • Emit override utilization only when resource counts are under threshold.
  • Override utilization accounts for anticipated issuance.
  • Correct the limit metric label for CertificatesPerName and CertificatesPerFQDNSet/Fast.

Part of #5545

@beautifulentropy beautifulentropy requested a review from a team as a code owner October 30, 2023 18:13
@beautifulentropy beautifulentropy marked this pull request as draft October 30, 2023 18:15
@beautifulentropy beautifulentropy marked this pull request as ready for review November 6, 2023 19:02
aarongable
aarongable reviewed Nov 7, 2023
View reviewed changes
ra/ra.go Outdated Show resolved Hide resolved
ra/ra.go Outdated Show resolved Hide resolved
ra/ra.go Show resolved Hide resolved
@aarongable aarongable requested a review from a team November 10, 2023 00:32
@beautifulentropy beautifulentropy mentioned this pull request Nov 14, 2023
Open
18 tasks
@pgporada pgporada merged commit e1312ff into main Nov 20, 2023
12 checks passed
@pgporada pgporada deleted the ratelimit-fix-override-util branch November 20, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@pgporada pgporada pgporada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @pgporada @aarongable