fixes #4 #9
Closed
fixes #4 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using "import { FaSolidMicrophoneAlt } from 'svelte-icons-pack';"
|
I think I found a way - will need more changes. Will resubmit once I get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4. See dylanblokhuis/svelte-feather-icons#10 for drawbacks, i.e. build time super slow if imported this way. With this, one can do
import { BsBox, Bs123, BsActivity, Icon } from "svelte-icons-pack";Another option is to put an index.ts in each subfolder and it should only build that icon pack.
I opted to not use it given the slowness in build but it doesn't break existing behavior so thought I'd submit.
Please feel free to modify and submit another PR if you think its still worth it or if there is a way to avoid the build delay.