feature: convert-keys run option #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job ! I'll just add a section in the README and tests and we're good to go ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new run option called
convert-keysas discussed in #129.Supported values:
snake,camel,kebab,none. Default value isnone.Example of running code generation:
Also, I suggest to use a separate package for converting to snake, camel, kebab case. I chose iancoleman/strcase as the most popular and well tested.
There was a bug in
SnakeCaseimplementation. For example,SnakeCase("Foo Bar")returnedfoo _barinstead offoo_bar. So I think it's not necessary to fix it and to implement other conversion functions while we can just use an appropriate package.