Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not panic on interrupt channel for watch #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: do not panic on interrupt channel for watch #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/command/watch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use crate::{
use anyhow::Result;
use leptos_hot_reload::ViewMacros;
use std::sync::Arc;
use tokio::sync::broadcast::error::RecvError;
use tokio::try_join;

pub async fn watch(proj: &Arc<Project>) -> Result<()> {
Expand Down Expand Up @@ -49,7 +50,12 @@ pub async fn run_loop(proj: &Arc<Project>) -> Result<()> {
loop {
log::debug!("Watch waiting for changes");

int.recv().await.dot()?;
let int = int.recv().await;
// Do not terminate the execution of watch if the receiver lagged behind as it might be a slow receiver
// It happens when many files are modified in short period and it exceeds the channel capacity.
if matches!(int, Err(RecvError::Closed)) {
return Err(RecvError::Closed).dot();
}

if Interrupt::is_shutdown_requested().await {
log::debug!("Shutting down");
Expand Down
Loading