Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display sorting indicator in DataGrid headers #1167

Conversation

stepwise-alan
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Currently, when using a DataGrid and sorting it by clicking on the header, the default behavior is to display a sorting indicator (▲|▼). However, this indicator is missing due to the applied header style in the project.

Issue Number: #1160

What is the new behavior?

  • The default sorting indicator (▲|▼) is now displayed correctly in DataGrid headers after applying a style.
  • The issue where the sorting indicator was missing has been fixed.

Other information

Before the change:

  • No sorting indicator was displayed in DataGrid headers when sorting columns.

After the change:

  • The sorting indicator is correctly displayed in DataGrid headers when sorting columns, improving user experience.

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request labels Jul 25, 2024
@pomianowski pomianowski deleted the branch lepoco:main July 26, 2024 12:02
@pomianowski pomianowski reopened this Jul 26, 2024
@pomianowski pomianowski changed the base branch from development to main July 26, 2024 12:06
@stepwise-alan
Copy link
Contributor Author

Closing this pull request as the sorting indicator fix is now part of a larger PR that resolves multiple issues related to DataGrid. Please check #1192 for the latest updates and consolidated changes. Thank you for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants