Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #94 #95

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Resolve #94 #95

merged 3 commits into from
Sep 7, 2018

Conversation

lehitoskin
Copy link
Owner

Seems to be operational on my end.

Copy link
Collaborator

@IonoclastBrigham IonoclastBrigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so this seems like one of those opportunities to not add a lot of overhead to the already-congested startup sequence. In particular, we're opening, reading, and decoding the file, extracting just the width and height, and closing it, just to do it all again when we load it into the canvas.

It'll take a bit of restructuring, but it should be a lot more efficient to have resize-ivy-frame operate on a loaded bitmap file, and instead call it from elsewhere, after the image is loaded. Maybe an optional boolean param for load-image to control whether to call it or not?

- Avoid loading the image multiple times
- Do not rely on pict library to determine scaling
- Remove pict from main.rkt
@lehitoskin
Copy link
Owner Author

@IonoclastBrigham These changes will allow it to reuse the already-loaded image-bmp-master and determine the frame dimensions by math instead of relying on the pict library to do the heavy lifting for us.

@IonoclastBrigham IonoclastBrigham merged commit 60cf5ac into master Sep 7, 2018
@IonoclastBrigham IonoclastBrigham deleted the application-handler branch September 7, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants