Improve tag-browser responsiveness #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (table-column 'tags 'Tag_Label)) | ||
| string<?)) | ||
| ; add them to the list-box, truncating if necessary | ||
| (send tag-lbox set |
IonoclastBrigham
approved these changes
Sep 4, 2018
| ; set data for the unmodified label string | ||
| (for ([img (in-list tag-labels)] | ||
| [n (in-naturals)]) | ||
| (send tag-lbox set-data n img)) |
There was a problem hiding this comment.
Although, doesn't this sort of negate the speed-up from calling set only once, above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed things up. I also made it so the completely unmodified string is added as raw data. This way even if a path or tag label is more than
+label-max+, we'll still be able to reference it without issue.