Simplify FLIF pass 1 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep as much of the FLIF stuff inside `flif->list` as possible - Needs cleanup of a bunch of old comments - Aborting decoding only necessary for progressive decoding
base.rkt
Outdated
| @@ -83,9 +83,9 @@ | |||
| ; number of times to loop a FLIF (0 = forever) | |||
| (define image-num-loops 0) | |||
| (define animation-thread (make-parameter #f)) | |||
| (define decoder-thread (make-parameter #f)) | |||
| ;(define decoder-thread (make-parameter #f)) | |||
There was a problem hiding this comment.
If these actually aren't used anywhere (and I see they're not) we prolly wanna delete the commented-out lines (unless you're planning to revive them very soon).
base.rkt
Outdated
| (define bitmap (make-object bitmap% width height #f #t)) | ||
| (send bitmap set-argb-pixels 0 0 width height pixels) | ||
| bitmap)) | ||
| ;(define width (flif-image-get-width image)) |
There was a problem hiding this comment.
Yeah, kill these lines. Could get confusing when casually perusing the code with these values "defined" in two places right by each other.
want-animation? passed as an optional keyword Get rid of bizarre parameterize in thumbnail generation
IonoclastBrigham
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flif->listas possible