Resolves and merges db vs xmp data when displaying an image. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are purely UI/data loading considerations. It is wholly non-destructive, and deciding which tags/rating to save for the image is left to the user.
Strategy was to first extract the rating loading code from the tag loading, then simplify db vs xmp codepaths to just set values which can be compared, and finally decide what to display when we know what's up.
I feel like this code is pretty clumsy and suboptimal, but it seems to behave correctly. We may want to simplify and clean it up further, before merging to
master
.Testing Note: Took me a while to realize that the XMP editor was clever enough to also update the database. This made it look like my code changes weren't working, because it still always just displayed what was set in the embedded tags. In order to force an image out of sync, I had to load up a SQLite editor and hack the appropriate rows manually.