Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Browser Enhancements #71

Merged
merged 7 commits into from
Apr 28, 2018
Merged

Tag Browser Enhancements #71

merged 7 commits into from
Apr 28, 2018

Conversation

IonoclastBrigham
Copy link
Collaborator

Fixes #68, plus the following enhancements to the tag browser:

  • Hides the thumb panel when switching to a new tag
  • Adds image count to "Image List" label
  • Tag search/filtering
    • Filters tag list in real time as the user types
    • Defaults to literal substring match
    • Checkbox for regex support

Known Issues

The image count label isn't displayed when there's more than 100 images associated with a tag. Looks like this might be a rendering bug in racket/gui?

@IonoclastBrigham
Ignore mac disk images.
106dcba
@IonoclastBrigham
Fixes lehitoskin#68: Long image paths in tag browser.
ea2b49c 
Truncate image paths > 200 chars long; they will cause lbox to throw.
When doing so, set the full path as attached data item.
Then, when loading selected item, check first for attached data, then
label.
@IonoclastBrigham
Hide thumb panel when switching tags in browser.
e09a44e
@IonoclastBrigham
Sets image count for selected tag in browser.
8efba88
@IonoclastBrigham
Tag filtering in browser.
d0097f5 
New filter text-field%.
On event, calls (update-tag-browser).
When loading tags, filter results to match input field.
@IonoclastBrigham
Adds a checkbox to control tag filtering substr vs regex.
31068a6
lehitoskin
lehitoskin requested changes Apr 28, 2018
View reviewed changes
Copy link
Owner

@lehitoskin lehitoskin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string-replace from srfi/13 behaves differently from the one in racket/string, so we must use racket/string. Revert the line back to racket/string and add (only-in srfi/13 string-contains-ci) to the list instead.

@IonoclastBrigham
PR lehitoskin#71 feedback: module imports.
6098374 
Restore racket/string import for its version of string-replace.
Specifically import string-contains-ci from srfi/13.
@IonoclastBrigham
Copy link
Collaborator Author

Updated.

@lehitoskin lehitoskin merged commit 6098374 into lehitoskin:master Apr 28, 2018
@IonoclastBrigham IonoclastBrigham deleted the brig/tag-browser branch April 28, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehitoskin lehitoskin lehitoskin approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IonoclastBrigham @lehitoskin