Tagged filters #66
Merged
Tagged filters #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New filter submenu. New untagged filter menu item. Filters for images in collection which don't have database entries. Commented-out stubs for `filter > tagged` and `filter > all`.
Moves Filter menu under File. Adds proper Tagged filter on model of Untagged. Gives up on the idea of an "All" filter, since filtering is destructive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
File > Filter > TaggedandFile > Filter > Untaggedmenu options, with shortcut keys ⌘T and ⌘U respectively.There's a bit of copypasta in there, so I'm not 100% sure how much of what I'm doing in the callbacks is strictly necessary or generally helpful. Could also abstract out the callback bodies with a higher-order function that returns a function, since they only differ in negating the filter predicate.