Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangene Revisions #404

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Pangene Revisions #404

merged 9 commits into from
Oct 24, 2024

Conversation

alancleary
Copy link
Contributor

@alancleary alancleary commented Oct 16, 2024

This PR includes the following changes:

This component implements the same interface as the loading component but can be used inline, e.g. next to the download button in a form. In addition to being an inline element, the distinguishing features of the inline loading component is that its loading spinner doesn't cover/disable other parts of the UI and result states are conveyed as icons rather than an alert element, with messages being shown in a tooltip on the icons.
Specifically, the downloading element should be an instance of the inline loading component. If present, it will be utilized to convey the status of a download request submitted by the search form.
This element is utilized by the underlying search mixins to convey the status of download requests initialized by the component's lookup form.
These are required by the inline loading component utilized by the pangene lookup component for its download button.
The search and paginated search mixins have been combined into one again. This is because their code was very redundant and hard to extend and debug. Also, no components were actually using the non-paginated search mixin.
This is controlled via a new queryStringReflection property, which is set to true by default.
This is mostly because the value of the genes form field may exceed the length limit of the web browser URL.
@alancleary alancleary added the enhancement New feature or request label Oct 16, 2024
@alancleary alancleary requested a review from adf-ncgr October 16, 2024 17:16
@adf-ncgr
Copy link
Contributor

hmm, looks like the fix did not actually solve #399 or else has transformed it into something a little different (my bad for not supplying more detail in that issue, going to update it now with some more info about what I'm seeing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants