Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release checklist #255

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Updated release checklist #255

merged 1 commit into from
Nov 9, 2023

Conversation

alancleary
Copy link
Contributor

@alancleary alancleary commented Nov 9, 2023

I skipped the review on the PR that added the checklist so I could use it for the v1.0.0 release. This let a few mistakes slip through so I'm fixing them now. Can someone scrutinize this to make sure there aren't any more mistakes?!

Added test building the NPM package and fixed a typo.
Copy link
Contributor

@sammyjava sammyjava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a local test build of the NPM package seems prudent.

@alancleary
Copy link
Contributor Author

Doing a local test build of the NPM package seems prudent.

Yeah, I did it for the v1.1.0 release but forgot to add it to the checklist! Thanks for taking a look.

@alancleary alancleary merged commit 30a8b17 into main Nov 9, 2023
1 check passed
@alancleary alancleary deleted the update-release-checklist branch November 27, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants