Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added math module back into pre-commit. Renamed classes following capitalization conventions. #576

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

SamuelBorden
Copy link
Collaborator

@gipert I've added the math module back into the pre-commit. I changed some variable names to all lowercase, and then changed all math distribution class names to uppercase. I fixed the imports related to this in math and pargen and fixed some docstrings that weren't compiling in pargen. Tests in math and pargen are still passing for me locally.

@SamuelBorden SamuelBorden requested a review from gipert April 26, 2024 18:35
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 67.03297% with 210 lines in your changes are missing coverage. Please review.

Project coverage is 50.05%. Comparing base (9b2e556) to head (ebfbe4c).

Files Patch % Lines
src/pygama/math/histogram.py 59.13% 47 Missing ⚠️
src/pygama/math/hpge_peak_fitting.py 66.23% 26 Missing ⚠️
src/pygama/math/functions/exgauss.py 52.63% 18 Missing ⚠️
src/pygama/math/functions/sum_dists.py 77.21% 18 Missing ⚠️
src/pygama/math/functions/gauss.py 39.28% 17 Missing ⚠️
src/pygama/math/functions/crystal_ball.py 57.14% 15 Missing ⚠️
src/pygama/math/functions/step.py 61.76% 13 Missing ⚠️
src/pygama/math/functions/exponential.py 66.66% 8 Missing ⚠️
src/pygama/math/functions/hpge_peak.py 55.55% 8 Missing ⚠️
src/pygama/math/functions/poisson.py 53.33% 7 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##           refactor     #576      +/-   ##
============================================
- Coverage     50.36%   50.05%   -0.31%     
============================================
  Files            63       63              
  Lines          7581     7581              
============================================
- Hits           3818     3795      -23     
- Misses         3763     3786      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert
Copy link
Member

gipert commented Apr 26, 2024

lovely, thanks a lot sam!

@gipert gipert merged commit 7950c34 into legend-exp:refactor Apr 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants