Switching the dataloader build_entry_list from pandas to polars #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior on tail to remove degeneracy, added check on guess so no guess params are none, bounded mu to be in fit range, improved validity checks
…rations, wrote resolution fitting to include both linear and quadratic fits, changed results output for clarity
… of results, split out plots into own functions
…ernal to main function
…ior on tail to remove degeneracy, added check on guess so no guess params are none, bounded mu to be in fit range, improved validity checks
…rations, wrote resolution fitting to include both linear and quadratic fits, changed results output for clarity
… of results, split out plots into own functions
…ernal to main function
…ed get_pulser_ids to get_tcm_pulser_ids, added ability to return mask for load_data
…entiate from normal timestamp
|
Jesus... what's this commit history? |
|
I see no problem..... |
|
It's because of the rebasing, will leave as this is just an exemplar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to give a decent speedup in testing, definitely more optimisation possible as well with using Lazy dataframes. have left the cut query as pandas as this needs a parser to work with polars