Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some basic documentation #54

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

tdixon97
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.71%. Comparing base (ad7b135) to head (5cb715b).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   77.86%   77.71%   -0.15%     
==========================================
  Files          16       15       -1     
  Lines         768      763       -5     
==========================================
- Hits          598      593       -5     
  Misses        170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/source/manual.rst Outdated Show resolved Hide resolved
Metadata specification
----------------------

The detector geometry is constructed based on the LEGEND metadata specification `(metadata-docs) <https://github.com/legend-exp/legend-detectors/tree/main/germanium/diodes>`_.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also link to the public testdata. Also mention that this link is private?

docs/source/manual.rst Outdated Show resolved Hide resolved

legendhpges can be installed with pip.

.. code-block:: console
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we advise users to directly install from PyPI, or to do an editable install (pip install **-e**)? With the current instructions, they have a code folder that they cannot edit, but might expect to be able to do so...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess that information can be added to some section on "developer instructions" or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants