Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric fix for histograms with small binning #102

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ManuelHu
Copy link
Contributor

Sorry for the noise, but here is another fix for my recently merged histogram implementation #98

It is most important for a variable binning with steps <~ 10e-8, which might have incorrectly been converted to a range object.
The fix is just to disable any automatic conversion from an edge array to a range object. The old functionality is still exposed as a separate function.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.30%. Comparing base (ad9684b) to head (60ff9bf).
Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   76.26%   76.30%   +0.03%     
==========================================
  Files          46       46              
  Lines        3029     3038       +9     
==========================================
+ Hits         2310     2318       +8     
- Misses        719      720       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert merged commit 1909c8d into legend-exp:main Aug 13, 2024
15 checks passed
@ManuelHu ManuelHu deleted the hist-fix branch August 13, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants