Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partitioninfo to filter categories #86

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

theHenks
Copy link
Collaborator

partitioninfo allows to filter for analysis_runs only to be able to parse :phy and :cal

@theHenks theHenks requested a review from fhagemann December 13, 2024 14:51
@theHenks theHenks added bug Something isn't working enhancement New feature or request labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 42.07%. Comparing base (0d3faa7) to head (c21b36c).

Files with missing lines Patch % Lines
src/dataprod_config.jl 77.77% 6 Missing ⚠️
src/utils/management_utils.jl 0.00% 1 Missing ⚠️
src/utils/pars_utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   41.95%   42.07%   +0.11%     
==========================================
  Files          26       26              
  Lines        1971     1975       +4     
==========================================
+ Hits          827      831       +4     
  Misses       1144     1144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I did not run the code. One minor comment

src/utils/pars_utils.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants