Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dot-based getproperty in ljl_propfunc #83

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented Dec 4, 2024

Also add support for square-brackets index access, the conditional ternary operator and functions one, zero and identity.

src/ljl_expressions.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 41.96%. Comparing base (3bf5c54) to head (c835c1f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ljl_expressions.jl 66.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   41.76%   41.96%   +0.19%     
==========================================
  Files          26       26              
  Lines        1942     1959      +17     
==========================================
+ Hits          811      822      +11     
- Misses       1131     1137       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz force-pushed the ljl-prop-access branch 6 times, most recently from 445f1ee to ac13b57 Compare December 4, 2024 20:40
@oschulz oschulz merged commit c835c1f into main Dec 4, 2024
11 checks passed
@oschulz oschulz deleted the ljl-prop-access branch December 4, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants