Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup table to generate FileKey Database #79

Merged
merged 19 commits into from
Dec 4, 2024
Merged

Lookup table to generate FileKey Database #79

merged 19 commits into from
Dec 4, 2024

Conversation

theHenks
Copy link
Collaborator

@theHenks theHenks commented Dec 3, 2024

This PR includes look-up functionality to generate a FileKey database. The database can be generated with:

l200 = LegendData(:l200)
ds = search_disk(DataSet, l200)

To search for a FileKey a LEGEND timestamp belongs to, you can use the find_filekey function.
For convenience, plot recipes have been added to plot a specific timestamp, either from phy or from cal data.

@theHenks theHenks requested a review from fhagemann December 3, 2024 11:14
@theHenks theHenks self-assigned this Dec 3, 2024
@theHenks theHenks added the enhancement New feature or request label Dec 3, 2024
Project.toml Outdated Show resolved Hide resolved
ext/LegendDataManagementLegendHDF5IOExt.jl Outdated Show resolved Hide resolved
ext/LegendDataManagementLegendHDF5IOExt.jl Show resolved Hide resolved
ext/LegendDataManagementPlotsExt.jl Show resolved Hide resolved
ext/LegendDataManagementPlotsExt.jl Outdated Show resolved Hide resolved
ext/LegendDataManagementPlotsExt.jl Outdated Show resolved Hide resolved
src/legend_data.jl Show resolved Hide resolved
src/legend_data.jl Show resolved Hide resolved
src/utils/pars_utils.jl Show resolved Hide resolved
src/ljl_expressions.jl Show resolved Hide resolved
docs/src/extensions.md Outdated Show resolved Hide resolved
docs/src/extensions.md Outdated Show resolved Hide resolved
docs/src/extensions.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 48 lines in your changes missing coverage. Please review.

Project coverage is 41.76%. Comparing base (8be1f46) to head (8b63b60).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/pars_utils.jl 0.00% 20 Missing ⚠️
src/legend_data.jl 48.38% 16 Missing ⚠️
ext/LegendDataManagementLegendHDF5IOExt.jl 0.00% 6 Missing ⚠️
src/filekey.jl 25.00% 3 Missing ⚠️
src/dataprod_config.jl 91.66% 2 Missing ⚠️
src/exposure.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   39.05%   41.76%   +2.70%     
==========================================
  Files          27       26       -1     
  Lines        1987     1942      -45     
==========================================
+ Hits          776      811      +35     
+ Misses       1211     1131      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann
Copy link
Contributor

fhagemann commented Dec 3, 2024

The introduction of OhMyThreads@>=0.5 requires StructArrays@>=0.6

@fhagemann
Copy link
Contributor

The last commit (setting StructArrays@>=0.6.6) will fix the failing Downgrade test, because of a fix when materializing a StructArray in broadcast, see JuliaArrays/StructArrays.jl#213.

@theHenks
Copy link
Collaborator Author

theHenks commented Dec 4, 2024

Thanks, this looks good from my side now

@fhagemann
Copy link
Contributor

I cleaned up the commit history a bit (stashing the fixes into the initial commits and omitting the merge commits)

@fhagemann
Copy link
Contributor

fhagemann commented Dec 4, 2024

@theHenks I wrote some tests, but I am abit confused by this commit message (cf74f7b):
image
because according to the tests, partitioninfo seems to return an IdDict.

EDIT: This is to be expected. The partitioninfo should be an IdDict that maps each DataPartition to a TypedTables.Table

@fhagemann fhagemann merged commit 3bf5c54 into main Dec 4, 2024
11 checks passed
@theHenks theHenks deleted the lookup-table branch December 4, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants