Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for SolidStateDetectors in [weakdeps] to 0.10.2 #71

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

fhagemann
Copy link
Contributor

This version bump is needed for the new implementation in the SolidStateDetectors extension to work.
(The charge drift model will otherwise not be parsed correctly)

Note: Wait with merging until SolidStateDetectors v0.10.1 is released.

@fhagemann fhagemann added the dependencies Pull requests that update a dependency file label Sep 25, 2024
@fhagemann
Copy link
Contributor Author

Re-run the tests tomorrow, when the General registry might be updated to include SolidStateDetectors v0.10.1

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.96%. Comparing base (2429887) to head (c82942b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   33.96%   33.96%           
=======================================
  Files          28       28           
  Lines        1946     1946           
=======================================
  Hits          661      661           
  Misses       1285     1285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann fhagemann changed the title Bump compat for SolidStateDetectors in [weakdeps] to 0.10.1 Bump compat for SolidStateDetectors in [weakdeps] to 0.10.2 Sep 26, 2024
@fhagemann
Copy link
Contributor Author

Update: there was some serious type piracy in SolidStateDetectors, which should be fixed in 0.10.2 once it's released.

@fhagemann fhagemann merged commit 50101bf into legend-exp:main Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant